A Variety of Zoom Enhancements #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once folks started using zoom, a variety of small enhancement requests came in. This PR covers all of them, covering several tickets. The issues resolved are: Closes surge-synthesizer#483. Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM switch, since all hosts support zoom. To make it testable, ahead of implementing DisplayInfo on linux, set the defaulted screen size to 1400x1050, a mid-range 15" laptop. Closes surge-synthesizer#433 Correct the error message at zoom time to explain we add a window-decoration-protection factor but don't show the confusing dimensions that result. Closes surge-synthesizer#473 Order and add separator to the setting menu to be more rational. Keep "About" at the end. Closes surge-synthesizer#457 If you ask for a zoom which outstrips screen parameters, rather than retain the current zoom look for the largest zoom that will fit those paramemters. Don't display the confusing-to-users message about how much space we are reserving for window decoration.
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
…ents-433 A Variety of Zoom Enhancements Former-commit-id: d9f0401ba1e9da822801eddd00ef93090c613b55 [formerly eff2b64] Former-commit-id: af1d61d2cd4ed9af671076e6e1c4b3033492f546 Former-commit-id: 22797a30f302aebb9b0194d989a83624a5286e86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once folks started using zoom, a variety of small enhancement
requests came in. This PR covers all of them, covering several
tickets.
The issues resolved are:
Closes #483.
Zoom implemented on linux; in doing so remove the HOST_SUPPORTS_ZOOM
switch, since all hosts support zoom. To make it testable, ahead
of implementing DisplayInfo on linux, set the defaulted screen size
to 1400x1050, a mid-range 15" laptop.
Closes #433
Correct the error message at zoom time to explain we add
a window-decoration-protection factor but don't show the
confusing dimensions that result.
Closes #473
Order and add separator to the setting menu to be more
rational. Keep "About" at the end.
Closes #457
If you ask for a zoom which outstrips screen parameters, rather than
retain the current zoom look for the largest zoom that will fit those
paramemters. Don't display the confusing-to-users message about how
much space we are reserving for window decoration.